Skip to content

test(frontend): fail CI on axe errors - #805

Draft
eatyourgreens wants to merge 1 commit into
masterfrom
test-a11y-errors
Draft

test(frontend): fail CI on axe errors#805
eatyourgreens wants to merge 1 commit into
masterfrom
test-a11y-errors

Conversation

@eatyourgreens

Copy link
Copy Markdown
Collaborator
  • configure Storybook to fail CI when axe reports accessibility errors.
  • fix reported errors.

@codecov

codecov Bot commented Jun 17, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.87%. Comparing base (0e96018) to head (87a1893).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #805      +/-   ##
==========================================
- Coverage   78.11%   75.87%   -2.25%     
==========================================
  Files         228      119     -109     
  Lines       24713     5831   -18882     
  Branches     1423        0    -1423     
==========================================
- Hits        19304     4424   -14880     
+ Misses       5351     1407    -3944     
+ Partials       58        0      -58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eatyourgreens
eatyourgreens force-pushed the test-a11y-errors branch 8 times, most recently from 99bd473 to 94cbfab Compare June 17, 2025 10:23
@eatyourgreens

Copy link
Copy Markdown
Collaborator Author

#806 fixed most of the accessibility errors that failed CI, except for these three:

  • Projects: colour contrast error in the project description modal. I think this is the light grey 'edit project description' label.
  • Trial Design: button nested inside another button. The 'Delete group' button is nested inside a tab, which is itself a button.
  • Results: button nested inside another button. The same error as Trial Design. You can't use a clickable IconButton as the icon for a tab.

@eatyourgreens
eatyourgreens force-pushed the test-a11y-errors branch 4 times, most recently from 02e9b5d to a783e78 Compare June 23, 2025 16:12
- configure Storybook to fail CI when axe reports accessibility errors.
- fix reported errors.
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant